HSEARCH-5385 Move SearchProjectionFactory into the context for ProjectionDefinition / HSEARCH-5384 Follow up on field refereces to simplify app migration #4623
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! This pull request appears to follow the contribution rules. › This message was automatically generated. |
marko-bekhta
force-pushed
the
fix/scope-type
branch
from
c960ef6 to
149406b
Compare
marko-bekhta
changed the title
marko-bekhta
force-pushed
the
fix/scope-type
branch
from
149406b to
3e0e00c
Compare
yrodiere
reviewed
May 27, 2025
There was a problem hiding this comment.
Found a TODO, see below.
Apart from that, this looks pretty nice. I generated a diff of APIs between 7.2 and now, and it looks rather unobtrusive? https://gist.github.com/yrodiere/d79439f897274b36dbc3888dcffa1d24
...csearch/src/main/java/org/hibernate/search/backend/elasticsearch/ElasticsearchExtension.java
Outdated
Show resolved
Hide resolved
...g/hibernate/search/integrationtest/backend/tck/search/predicate/KnnPredicateSpecificsIT.java
Outdated
Show resolved
Hide resolved
HSEARCH-5384 Check typed predicate definition compatibility HSEARCH-**** WIP HSEARCH-**** Use typed predicate definition
marko-bekhta
force-pushed
the
fix/scope-type
branch
from
3e0e00c to
f144db4
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://hibernate.atlassian.net/browse/HSEARCH-5384
https://hibernate.atlassian.net/browse/HSEARCH-5385
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license
and can be relicensed under the terms of the LGPL v2.1 license in the future at the maintainers' discretion.
For more information on licensing, please check here.